[FFmpeg-devel] [PATCH 1/2] avcodec/v4l2_context: Use av_freep

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Mon Apr 6 10:37:41 EEST 2020


Andriy Gelman:
> From: Andriy Gelman <andriy.gelman at gmail.com>
> 
> Signed-off-by: Andriy Gelman <andriy.gelman at gmail.com>
> ---
>  libavcodec/v4l2_context.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c
> index 8110bbb555..31af10d28e 100644
> --- a/libavcodec/v4l2_context.c
> +++ b/libavcodec/v4l2_context.c
> @@ -685,8 +685,7 @@ void ff_v4l2_context_release(V4L2Context* ctx)
>      if (ret)
>          av_log(logger(ctx), AV_LOG_WARNING, "V4L2 failed to unmap the %s buffers\n", ctx->name);
>  
> -    av_free(ctx->buffers);
> -    ctx->buffers = NULL;
> +    av_freep(&ctx->buffers);
>  }
>  
>  int ff_v4l2_context_init(V4L2Context* ctx)
> @@ -743,8 +742,7 @@ int ff_v4l2_context_init(V4L2Context* ctx)
>  error:
>      v4l2_release_buffers(ctx);
>  
> -    av_free(ctx->buffers);
> -    ctx->buffers = NULL;
> +    av_freep(&ctx->buffers);
>  
>      return ret;
>  }
> 
LGTM.

- Andreas


More information about the ffmpeg-devel mailing list