[FFmpeg-devel] [PATCH v12] libavcodec/jpeg2000dec.c: Add support for PPT marker

Moritz Barsnick barsnick at gmx.net
Sun Apr 5 12:38:18 EEST 2020


On Sun, Apr 05, 2020 at 10:28:17 +0530, gautamramk at gmail.com wrote:
> +    tile->has_ppt = 1;  // this tile has a ppt marker
> +/*    Zppt = */ bytestream2_get_byte(&s->g); // Zppt is skipped and not used

I don't know what others think, but, as mentioned in my first review, I
really dislike this style, because it gives the impression that this
line is commented out, when just skimming over the code.

How about just:
    bytestream2_get_byte(&s->g); // skip Zppt
?

Thanks,
Moritz


More information about the ffmpeg-devel mailing list