[FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

Nicolas George george at nsup.org
Sat Apr 4 12:42:06 EEST 2020


Limin Wang (12020-04-04):
> I think it's caused by the keyframe flags, so have no clue how to check
> the beneficial for these fate testing.

Take the actual files produced by the tests, possibly changing the
output format from framecrc to an actual format, and compare carefully
the version before the patch and the version after the patch.

Tests are there for a reason. If you cannot explain exactly why a change
in a reference file is beneficial, then the patch is not acceptable.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200404/2b19b745/attachment.sig>


More information about the ffmpeg-devel mailing list