[FFmpeg-devel] [PATCH v2 2/2] avcodec/libaomenc.c: Add super-resolution options to libaom wrapper

[Wang Cao]

On Wed, Mar 18, 2020 at 6:38 AM James Zern <jzern at google.com> wrote:

> Hi,
>
> On Thu, Mar 5, 2020 at 6:20 PM Wang Cao <doubleecao at gmail.com> wrote:
> >
> > Signed-off-by: Wang Cao <wangcao at google.com>
> > ---
> > The changes are made according to the code review
> > - Bump the MICRO version
> > - Use enum for Super resolution mode consts. The original enum in libaom
> >   is not public so a enum is defined and matched the original enum
> >  doc/encoders.texi      | 39 +++++++++++++++++++++++++++++++++++
> >  libavcodec/libaomenc.c | 47 ++++++++++++++++++++++++++++++++++++++++++
> >  libavcodec/version.h   |  2 +-
> >  3 files changed, 87 insertions(+), 1 deletion(-)
> >
> > diff --git a/doc/encoders.texi b/doc/encoders.texi
> > index 0a74ecce9b..04f05e7c9b 100644
> > --- a/doc/encoders.texi
> > +++ b/doc/encoders.texi
> > @@ -1608,6 +1608,45 @@ Enable the use of global motion for block
> prediction. Default is true.
> >  Enable block copy mode for intra block prediction. This mode is
> >  useful for screen content. Default is true.
> >
> > + at item enable-superres (@emph{boolean})
> > +Enable super-resolution during the encoding process.
> > +
>
> Funny aomenc in libaom doesn't have this option. It must assume the
> library defaults will take care of it, seems like a bug.
>
> Yes they use a default value "1" for this internally (
https://aomedia.googlesource.com/aom/+/master/av1/av1_cx_iface.c).

> > + at item superres-mode (@emph{mode})
> > +Select super-resultion mode.
> > +
>
> resolution
>
I will send a new patch to apply the changes you mentioned.
-- 

Wang Cao |  Software Engineer |  wangcao at google.com |  650-203-7807