[FFmpeg-devel] [PATCH] avformat/img2dec: return immediately in jpeg_probe() when EOI is found

Matthieu Bouron matthieu.bouron at gmail.com
Wed Apr 1 19:34:55 EEST 2020


On Wed, Apr 01, 2020 at 06:29:03PM +0200, Carl Eugen Hoyos wrote:
> Am Mi., 1. Apr. 2020 um 18:01 Uhr schrieb Matthieu Bouron
> <matthieu.bouron at gmail.com>:
> >
> > Fixes probing of JPEG files containing MPF metadata appended at the end
> > of the file.
> >
> > The MPF metadata chunk can contains multiple JPEG images (thumbnails)
> > which makes the jpeg_probe fails (return 0) because it finds a SOI
> > marker after EOI.
> > ---
> >
> > This patch fixes probing of JPEG files containing MPF metadata [1] appended
> > at the end of the file.
> >
> > Such files can be produced by GoPro camera (which produces JPEG files
> > with MPF metadata).
> >
> > You can find a sample here:
> > https://0x5c.me/gopro_jpg_mpf_probe_fail
> 
> The sample works fine here with FFmpeg 4.2: Is there a regression?

This sample does not work on FFmpeg 4.2 and master if you set a big
enought formatprobesize (which matches the file size of the sample):

ffmpeg -formatprobesize 5000000 -i ~/gopro_jpg_mpf_probe_fail gives:

/home/mateo/gopro_jpg_mpf_probe_fail: Invalid data found when processing
input

> 
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

-- 
Matthieu B.


More information about the ffmpeg-devel mailing list