[FFmpeg-devel] [PATCH v4 2/2] avfilter: Add tonemap vaapi filter

Zachary Zhou zachary.zhou at intel.com
Wed Sep 25 05:10:35 EEST 2019


On 9/16/19 7:36 PM, Carl Eugen Hoyos wrote:
> Am Mi., 11. Sept. 2019 um 23:02 Uhr schrieb Carl Eugen Hoyos
> <ceffmpeg at gmail.com>:
>> Am Mi., 11. Sept. 2019 um 07:41 Uhr schrieb Zachary Zhou
>> <zachary.zhou at intel.com>:
>>> It supports ICL platform.
>>> H2H (HDR to HDR): P010 -> A2R10G10B10
>>> H2S (HDR to SDR): P010 -> ARGB
>>> +    if (ctx->hdr_type == HDR_VAAPI_H2H) {
>>> +        vpp_ctx->output_format = AV_PIX_FMT_A2R10G10B10;
>> I believe that even if you tell me that a conversion to planar on the
>> gpu is impossible (why?), a slow C conversion still makes the filter
>> more useful.
> Ping.

Thank Carl for the comment, current H2H support A2R10G10B10 output, I am 
not sure H2H will support planar P010 output, I agree support P010 
output will get more benefit for encode.

in another side, iHD driver already support A2R10G10B10 as input for 
HEVC encode: 
https://github.com/intel/media-driver/commit/6b74dac6bcb722f4cdb71b5d6a2bd0a1e5af7237

on H2S side, we can use scale_vaapi=format=nv12 to do the Conversion for 
ARGB, So I think maybe ffmpeg can also do the conversion from 
A2R10G10B10 to P010.

As my local test, the the conversion from A2R10G10B10 to P010 is also 
works for VAAPI.

So, Do you think we add another filter to command line 
"scale_vaapi=format=p010" for do the conversion after the filter 
tonemap_vaapi is reasonable ?

Sorry for late reply.

-Zach


>
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list