[FFmpeg-devel] [PATCH v1 1/4] avfilter/vf_framerate: add flags none to disable scene change detection if necessary

[Limin Wang]

On Mon, Sep 23, 2019 at 11:18:01PM +0200, Marton Balint wrote:
> 
> 
> On Mon, 23 Sep 2019, Limin Wang wrote:
> 
> >On Sun, Sep 22, 2019 at 08:54:36PM +0200, Marton Balint wrote:
> >>
> >>
> >>On Sat, 21 Sep 2019, lance.lmwang at gmail.com wrote:
> >>
> >>>From: Limin Wang <lance.lmwang at gmail.com>
> >>>
> >>>Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> >>>---
> >>>doc/filters.texi           |  2 ++
> >>>libavfilter/vf_framerate.c | 17 +++++++++++------
> >>>2 files changed, 13 insertions(+), 6 deletions(-)
> >>>
> >>>diff --git a/doc/filters.texi b/doc/filters.texi
> >>>index bbfdad4..fce4ef4 100644
> >>>--- a/doc/filters.texi
> >>>+++ b/doc/filters.texi
> >>>@@ -10637,6 +10637,8 @@ Specify flags influencing the filter process.
> >>>Available value for @var{flags} is:
> >>>
> >>>@table @option
> >>>+ at item none
> >>>+Disable scene change detection
> >>
> >>This is only true if no additional flags are added later. The reason
> >>of using a flags option is future extensibility, so adding such a
> >>constant kind of defeats that purpose. It is also uneeded, "none" is
> >>a a named constant which you can always use to explicitly set no
> >>flags.
> >>
> >>So this patch seems uneeded.
> >
> >Marton, thanks for your review, the none flags is for debug
> >purpose, without sceencut detection, the result will consistent.
> >So it's
> >necessary to have none flags to turn it off.
> 
> You can change flags using the +flag or -flag syntax. You don't need
> a separate constant for this.
OK, thank for the hint, I don't know it's supporot -flag with one only
although I have used flag+flag before. Any comments for the other
patches, if ok, I'll update the patch and remove this one.

> 
> Regards,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".