[FFmpeg-devel] [PATCH 1/3] avcodec/mpeg4audio: add a logging context parameter to avpriv_mpeg4audio_get_config()

[James Almer]

On 9/21/2019 7:42 PM, Carl Eugen Hoyos wrote:
> Am So., 22. Sept. 2019 um 00:40 Uhr schrieb James Almer <jamrial at gmail.com>:
>>
>> On 9/21/2019 7:38 PM, Carl Eugen Hoyos wrote:
>>> Am So., 22. Sept. 2019 um 00:36 Uhr schrieb James Almer <jamrial at gmail.com>:
>>>>
>>>> On 9/21/2019 7:31 PM, Carl Eugen Hoyos wrote:
>>>>> Am Sa., 21. Sept. 2019 um 17:53 Uhr schrieb James Almer <jamrial at gmail.com>:
>>>>>
>>>>>> This is an ABI change, so it's scheduled for the next bump.
>>>>>
>>>>> Why don't you add avpriv_mpeg4audio_get_config2() now?
>>>>
>>>> I don't like the idea of adding a function that will be gone as soon as
>>>> we bump (and still require line changes in lavf once it's removed).
>>>
>>> Don't remove it.
>>
>> Why would i leave a redundant internal function?
> 
> Drop avpriv_mpeg4audio_get_config(), keep avpriv_mpeg4audio_get_config2().

Yes, of course, but i'm talking about the name. I'll be dropping the old
function as soon as we bump, but also ensuring the new one starts using
the old name.

> 
>>>> But if that's preferred to get the logging context in lavf working right
>>>> now, then i can do it.
>>>
>>> It's just less ugly and it avoids code changes for third parties.
>>
>> What third parties? This is not public API.
> 
> True, it's still less ugly.

Alright, will do that instead.

> 
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>