[FFmpeg-devel] [PATCH 1/3] avcodec/mpeg4audio: add a logging context parameter to avpriv_mpeg4audio_get_config()

Carl Eugen Hoyos ceffmpeg at gmail.com
Sun Sep 22 01:38:29 EEST 2019


Am So., 22. Sept. 2019 um 00:36 Uhr schrieb James Almer <jamrial at gmail.com>:
>
> On 9/21/2019 7:31 PM, Carl Eugen Hoyos wrote:
> > Am Sa., 21. Sept. 2019 um 17:53 Uhr schrieb James Almer <jamrial at gmail.com>:
> >
> >> This is an ABI change, so it's scheduled for the next bump.
> >
> > Why don't you add avpriv_mpeg4audio_get_config2() now?
>
> I don't like the idea of adding a function that will be gone as soon as
> we bump (and still require line changes in lavf once it's removed).

Don't remove it.

> But if that's preferred to get the logging context in lavf working right
> now, then i can do it.

It's just less ugly and it avoids code changes for third parties.

Carl Eugen


More information about the ffmpeg-devel mailing list