[FFmpeg-devel] [PATCH v3 5/5] avcodec/v210enc: move the duplicate code to template file

Michael Niedermayer michael at niedermayer.cc
Tue Sep 17 02:16:36 EEST 2019


On Mon, Sep 16, 2019 at 07:17:52PM +0800, Limin Wang wrote:
> On Mon, Sep 16, 2019 at 12:21:36PM +0200, Michael Niedermayer wrote:
> > On Sun, Sep 01, 2019 at 09:20:23PM +0800, lance.lmwang at gmail.com wrote:
> > > From: Limin Wang <lance.lmwang at gmail.com>
> > > 
> > > Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> > > ---
> > >  libavcodec/v210_template.c |  59 +++++++++++++++++++++-
> > >  libavcodec/v210enc.c       | 123 +++++++--------------------------------------
> > >  2 files changed, 75 insertions(+), 107 deletions(-)
> > 
> > [PATCH v3 3/5] avcodec/v210enc: move the duplicate code to template file
> > [PATCH v3 5/5] avcodec/v210enc: move the duplicate code to template file
> > 
> > why do 2 patches have the same first line in the commit message ?
> It's for split the patch for review, 3/5 is move v210_planar_pack, 5/5 is moving 
> v210enc related function, so the code is different.

If the same description is good for different changes then the description
is not very good (not specific enough) IMO

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190917/804a5632/attachment.sig>


More information about the ffmpeg-devel mailing list