[FFmpeg-devel] [PATCH, v2 1/6] lavu/pixfmt: add new pixel format ayuv/y210/y410

[Fu, Linjie]

> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
> Of Carl Eugen Hoyos
> Sent: Saturday, September 14, 2019 00:31
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH, v2 1/6] lavu/pixfmt: add new pixel
> format ayuv/y210/y410
> 
> Am Fr., 13. Sept. 2019 um 18:13 Uhr schrieb Fu, Linjie <linjie.fu at intel.com>:
> >
> > > -----Original Message-----
> > > From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On
> Behalf
> > > Of Michael Niedermayer
> > > Sent: Friday, September 13, 2019 23:11
> > > To: FFmpeg development discussions and patches <ffmpeg-
> > > devel at ffmpeg.org>
> > > Subject: Re: [FFmpeg-devel] [PATCH, v2 1/6] lavu/pixfmt: add new pixel
> > > format ayuv/y210/y410
> > >
> > > On Thu, Sep 12, 2019 at 12:28:41AM +0800, Linjie Fu wrote:
> > > > Previously, media driver provided planar format(like 420 8 bit),
> > > > but for HEVC Range Extension (422/444 8/10 bit), the decoded image
> > > > is produced in packed format because Windows expects it.
> > > >
> > > > Add some packed pixel formats for hardware decode support in VAAPI
> > > > and QSV:
> > > >
> > > > 4:2:2 10 bit: Y210
> > > > 4:4:4  8 bit: AYUV
> > > > 4:4:4 10 bit: Y410
> > > >
> > > > Signed-off-by: Linjie Fu <linjie.fu at intel.com>
> > > > ---
> > > >  libavutil/pixdesc.c           | 62
> > > +++++++++++++++++++++++++++++++++++++++++++
> > > >  libavutil/pixfmt.h            |  9 +++++++
> > > >  libavutil/tests/pixfmt_best.c |  1 +
> > > >  libavutil/version.h           |  2 +-
> > > >  4 files changed, 73 insertions(+), 1 deletion(-)
> > >
> > > breaks fate
> > >
> > > --- ./tests/ref/fate/pixfmt_best      2019-09-11 20:36:09.435012759 +0200
> > > +++ tests/data/fate/pixfmt_best       2019-09-13 17:09:53.430392453 +0200
> > > @@ -1 +1 @@
> > > -73 tests passed, 0 tests failed.
> > > +74 tests passed, 0 tests failed.
> > > Test pixfmt_best failed. Look at tests/data/fate/pixfmt_best.err for
> details.
> > > make: *** [fate-pixfmt_best] Error 1
> > >
> >
> > If I didn't get anything missed in the upstream patch, this patch set has
> passed
> > the pre-patch check in https://github.com/intel-media-ci/ffmpeg/pull/88,
> > which includes the fate check.
> 
> Apparently not.
> 
> > Above fate breaking will gone after applying patch 3/6 in the patch set:
> > https://patchwork.ffmpeg.org/patch/15007/
> 
> This indicates you have to merge part(s) of the patches.
> The idea is of course that no patch breaks fate.
> 

Thanks, no single patch breaks fate is reasonable, will include the pixel format
query support in this patch and move the pixfmt_best modification to the fate
patch.

linjie