[FFmpeg-devel] [PATCH] avformat/dashdec: fix pointer being freed was not allocated

vectronic hello.vectronic at gmail.com
Fri Sep 13 19:30:12 EEST 2019


prevent attempt to call xmlFree if val was not allocated

fixes: 8135
Signed-off-by: vectronic <hello.vectronic at gmail.com>
---
 libavformat/dashdec.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 4f725ba09a..8022ba9afe 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -1185,6 +1185,7 @@ static int parse_programinformation(AVFormatContext *s, xmlNodePtr node)
 
     node = xmlFirstElementChild(node);
     while (node) {
+        val = NULL;
         if (!av_strcasecmp(node->name, "Title")) {
             val = xmlNodeGetContent(node);
             if (val) {
@@ -1202,7 +1203,9 @@ static int parse_programinformation(AVFormatContext *s, xmlNodePtr node)
             }
         }
         node = xmlNextElementSibling(node);
-        xmlFree(val);
+        if (val) {
+            xmlFree(val);
+        }
     }
     return 0;
 }
-- 
2.20.1 (Apple Git-117)



More information about the ffmpeg-devel mailing list