[FFmpeg-devel] [PATCH V1 1/4] lavfi/anequalizer: fix memory leak in error handling path

Paul B Mahol onemda at gmail.com
Tue Sep 10 16:05:54 EEST 2019


lgtm

On 9/10/19, Jun Zhao <mypopydev at gmail.com> wrote:
> From: Jun Zhao <barryjzhao at tencent.com>
>
> free the pad.name in error handling path to avoid memory leak.
>
> Signed-off-by: Jun Zhao <barryjzhao at tencent.com>
> ---
>  libavfilter/af_anequalizer.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/libavfilter/af_anequalizer.c b/libavfilter/af_anequalizer.c
> index 03d939f..ee82474 100644
> --- a/libavfilter/af_anequalizer.c
> +++ b/libavfilter/af_anequalizer.c
> @@ -205,8 +205,10 @@ static av_cold int init(AVFilterContext *ctx)
>              .type         = AVMEDIA_TYPE_VIDEO,
>              .config_props = config_video,
>          };
> -        if (!vpad.name)
> +        if (!vpad.name) {
> +            av_freep(&pad.name);
>              return AVERROR(ENOMEM);
> +        }
>      }
>
>      ret = ff_insert_outpad(ctx, 0, &pad);
> --
> 1.7.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list