[FFmpeg-devel] [PATCH] tests: Fix bash errors in lavf_container tests.
Limin Wang
lance.lmwang at gmail.com
Sat Sep 7 18:32:16 EEST 2019
On Sat, Sep 07, 2019 at 05:19:55PM +0200, Michael Niedermayer wrote:
> On Wed, Aug 28, 2019 at 06:32:37PM +0300, Andrey Semashev wrote:
> > Because lavf_container is sometimes called with only 2 arguments,
> > fate tests produce bash errors like this:
> >
> > tests/fate-run.sh: 299: test: =: unexpected operator
> >
> > This commit fixes this.
> > ---
> > tests/fate-run.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I think this change is correct but shell is not my area ...
If the $2 is two arguments between with space, the patch is needed.
Why I haven't got such errors when I'm running fate?
>
> [...]
>
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Its not that you shouldnt use gotos but rather that you should write
> readable code and code with gotos often but not always is less readable
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
More information about the ffmpeg-devel
mailing list