[FFmpeg-devel] [PATCH 2/2] avcodec/qdm2: Check frame size

Paul B Mahol onemda at gmail.com
Sat Sep 7 00:08:06 EEST 2019


Are you sure this is not band aid but actually real fix?

On 8/29/19, Michael Niedermayer <michael at niedermayer.cc> wrote:
> Fixes: index 2304 out of bounds for type 'float [2304]'
> Fixes:
> 16332/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDM2_fuzzer-5679142481166336
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/qdm2.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/libavcodec/qdm2.c b/libavcodec/qdm2.c
> index eaffb36dcc..ac8ae8cbbb 100644
> --- a/libavcodec/qdm2.c
> +++ b/libavcodec/qdm2.c
> @@ -1727,6 +1727,11 @@ static av_cold int qdm2_decode_init(AVCodecContext
> *avctx)
>      s->sub_sampling = s->fft_order - 7;
>      s->frequency_range = 255 / (1 << (2 - s->sub_sampling));
>
> +    if (s->frame_size * 4 >> s->sub_sampling > MPA_FRAME_SIZE) {
> +        avpriv_request_sample(avctx, "large frames");
> +        return AVERROR_PATCHWELCOME;
> +    }
> +
>      switch ((s->sub_sampling * 2 + s->channels - 1)) {
>          case 0: tmp = 40; break;
>          case 1: tmp = 48; break;
> --
> 2.23.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list