[FFmpeg-devel] [PATCH] avcodec/webp: avoid trying to decode trailing junk in bitstreams

Michael Niedermayer michael at niedermayer.cc
Fri Sep 6 19:20:55 EEST 2019


On Fri, Sep 06, 2019 at 01:11:50PM +0200, Pascal Massimino wrote:
> Michael,
> 
> On Thu, Sep 5, 2019 at 6:20 PM Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > On Wed, Sep 04, 2019 at 07:43:15AM +0200, Pascal Massimino wrote:
[...]

> >
> > i would guess its not a known chunk but rather hits the default
> > is that just a bunch of 0 or 0xFF bytes ?
> > detecting before we read into the end feels more robust if
> > we can simply detect the "junk"
> >
> 
> As i mentioned in the description, a possibly more robust solution would be
> just stopping the loop as soon as 'chunk_size' bytes have been consumed
> (leading to *got_frame = 1) and no more. This current patch is minimalist,
> though.

well, which solution do you prefer ?

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190906/18d59489/attachment.sig>


More information about the ffmpeg-devel mailing list