[FFmpeg-devel] [PATCH] lavc/v4l2_m2m: don't close the file descriptor we don't own

[Nicolas George]

Pavel Koshevoy (12019-09-02):
> ff_v4l2_m2m_create_context initialized V4L2m2mContext.fd to 0
> which is a valid file descriptor value. Next ff_v4l2_m2m_codec_init
> failed and v4l2_m2m_destroy_context closed file descriptor 0 even
> though it didn't belong to V4L2m2mContext.
> ---
>  libavcodec/v4l2_m2m.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/v4l2_m2m.c b/libavcodec/v4l2_m2m.c
> index 427e165f58..ac583c811f 100644
> --- a/libavcodec/v4l2_m2m.c
> +++ b/libavcodec/v4l2_m2m.c
> @@ -401,6 +401,7 @@ int ff_v4l2_m2m_create_context(AVCodecContext *avctx, V4L2m2mContext **s)
>      priv->context->capture.num_buffers = priv->num_capture_buffers;
>      priv->context->output.num_buffers  = priv->num_output_buffers;
>      priv->context->self_ref = priv->context_ref;
> +    priv->context->fd = -1;
>  
>      return 0;
>  }

This change looks ok to me, but I do not maintain that file.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190902/7647ee65/attachment.sig>