[FFmpeg-devel] [PATCH/RFC] libavcodec/cinepak: Separate decoding from parsing

Carl Eugen Hoyos ceffmpeg at gmail.com
Mon Sep 2 00:07:06 EEST 2019


Am So., 1. Sept. 2019 um 22:58 Uhr schrieb Tomas Härdin <tjoppen at acc.umu.se>:

> Attached patch separates parsing from decoding in the Cinepak decoder.
> It puts in some rather strict checks which are in line with how I've
> figured the VfW 1.1 decoder works. Parsing is still intermixed with
> validation, but the code should be much easier to read this way
> compared to before. Some avpriv_request_sample()s should probably be
> switched to outright rejection, I haven't decided yet

Your patch looks to me as if it would break decoding broken samples
instead of returning as much decoded data as is possible with the
input.

Carl Eugen


More information about the ffmpeg-devel mailing list