[FFmpeg-devel] [PATCH 1/4] avcodec/apedec: Fixes integer overflow of res+*data in do_apply_filter()

Michael Niedermayer michael at niedermayer.cc
Wed Oct 30 00:35:02 EET 2019


Fixes: signed integer overflow: 7400 + 2147482786 cannot be represented in type 'int'
Fixes: 18405/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5708834760294400

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavcodec/apedec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c
index 2dd197a7f2..3880e265ee 100644
--- a/libavcodec/apedec.c
+++ b/libavcodec/apedec.c
@@ -1271,7 +1271,7 @@ static void do_apply_filter(APEContext *ctx, int version, APEFilter *f,
                                                      f->adaptcoeffs - order,
                                                      order, APESIGN(*data));
         res = (int)(res + (1U << (fracbits - 1))) >> fracbits;
-        res += *data;
+        res += (unsigned)*data;
         *data++ = res;
 
         /* Update the output history */
-- 
2.23.0



More information about the ffmpeg-devel mailing list