[FFmpeg-devel] [PATCH v3] avcodec/libdav1d: fix setting AVFrame reordered_opaque

James Almer jamrial at gmail.com
Fri Oct 18 18:26:41 EEST 2019


On 10/18/2019 12:14 PM, Andrey Semashev wrote:
> On 2019-10-18 15:52, James Almer wrote:
>> On 10/18/2019 7:22 AM, Andrey Semashev wrote:
>>> Actually reorder the values.
>>>
>>> Should effectively fix ticket #8300.
>>>
>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>>
>>> Updated to avoid extra memory allocations on 64-bit platforms.
>>>
>>> Signed-off-by: Andrey Semashev <andrey.semashev at gmail.com>
>>
>> Please stop sending patches by other people with the authorship changed,
>> even if you modified it somewhat.
>>
>> Suggest changes, or ask if I'm ok with you taking over the patch.
>> Anything else will more likely than not be seen as rude by anyone.
> 
> Sorry, I didn't mean to offend anyone. I honestly don't understand the
> problem. I didn't claim the credit for the original change and I did
> preserve your comment and Signed-off-by, didn't I? Is there something
> else that I should have done?

Yes, you should have kept the original author name. "git commit
--author="foo <bar>" or just "git commit --amend" should be enough to
preserve authorship.
If this patch was committed as is, it would be under your name.

> 
> My aim was to demonstrate my suggestion and perhaps simplify your work.
> I don't care if my changes are taken or modified, credited or not. If
> that is not wanted, that is fine, I won't send any more patches.

Patches are welcome, always. Just keep etiquette in mind (Don't take
over patches without asking first, don't change authorship, etc).


More information about the ffmpeg-devel mailing list