[FFmpeg-devel] [PATCH] avfilter: add tdisplace filter

[Moritz Barsnick]

Hi Paul,
interesting concept!

On Wed, Oct 16, 2019 at 20:35:46 +0200, Paul B Mahol wrote:

Doc nits:

> +It takes two input streams and outputs one stream, the first input is the
> +source, and second input in temporal displacement map.

"in" seems misplaced. Probably:

[...]
, the first input is the source, the second input the temporal
displacement map.

> +If temporal displacement map stream terminates, last frame from that stream
> +will be used.

->
If the temporal displacement map stream terminates, the last frame from
that stream will be used.

> + at table @option
> + at item edge
> +Set temporal displacement radius. Any value present in temporal displacement
> +map which is higher/lower than this one will be clipped.
> +Allowed range is from 1 to 127. Default is 127.
> + at end table

What's the unit of this clipping limit, and what's the unit of the
displacement value found in the second stream? PTS, i.e. based in TB?
Number of frames? (Looks like no. of frames from the source.) Needs to
be mentioned somewhere.

Nothing else obvious that comes to my eyes.

Cheers,
Moritz