[FFmpeg-devel] [PATCH 01/14] avutil/opt: add AV_OPT_FLAG_RUNTIME_PARAM flag
Nicolas George
george at nsup.org
Sun Oct 13 20:34:22 EEST 2019
Paul B Mahol (12019-10-10):
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
> libavutil/opt.h | 1 +
> 1 file changed, 1 insertion(+)
The patch series looks reasonable on the whole. It changes the return
code of process_command() in a few cases, but that should not have
consequences.
But it is completely missing the user documentation. I suggest to add a
paragraph like that at the appropriate place:
Changing options at runtime with a command.
Some options can be changed during the operation of the filter using
a command. These options are marked 'R' on the output of `ffmpeg -h
filter=...`. The name of the command is the name of the option and
the argument is the new value.
Then, for each option newly marked with this flag:
This option can be changed at runtime with a command. See *Changing
options at runtime with a command.* for details.
I think that should be enough.
Regards,
--
Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191013/7e02bb41/attachment.sig>
More information about the ffmpeg-devel
mailing list