[FFmpeg-devel] [PATCH V1 2/3] fftools/ffmpeg_opt: add error handle if av_asprintf return null

Jun Zhao mypopydev at gmail.com
Sat Oct 12 04:14:39 EEST 2019


From: Jun Zhao <barryjzhao at tencent.com>

add error handle if av_asprintf return null.

Signed-off-by: Jun Zhao <barryjzhao at tencent.com>
---
 fftools/ffmpeg_opt.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index fa22eb3..af9a9a6 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -3008,6 +3008,8 @@ static int opt_old2new(void *optctx, const char *opt, const char *arg)
 {
     OptionsContext *o = optctx;
     char *s = av_asprintf("%s:%c", opt + 1, *opt);
+    if (!s)
+        return AVERROR(ENOMEM);
     int ret = parse_option(o, s, arg, options);
     av_free(s);
     return ret;
@@ -3039,6 +3041,8 @@ static int opt_qscale(void *optctx, const char *opt, const char *arg)
         return parse_option(o, "q:v", arg, options);
     }
     s = av_asprintf("q%s", opt + 6);
+    if (!s)
+        return AVERROR(ENOMEM);
     ret = parse_option(o, s, arg, options);
     av_free(s);
     return ret;
@@ -3084,6 +3088,8 @@ static int opt_timecode(void *optctx, const char *opt, const char *arg)
 {
     OptionsContext *o = optctx;
     char *tcr = av_asprintf("timecode=%s", arg);
+    if (!tcr)
+        return AVERROR(ENOMEM);
     int ret = parse_option(o, "metadata:g", tcr, options);
     if (ret >= 0)
         ret = av_dict_set(&o->g->codec_opts, "gop_timecode", arg, 0);
-- 
1.7.1



More information about the ffmpeg-devel mailing list