[FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

[Peter Ross]

On Fri, Oct 11, 2019 at 12:40:07AM +0200, Michael Niedermayer wrote:
> Fixes: signed integer overflow: 1092624416 * 2 cannot be represented in type 'int'
> Fixes: 18045/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINKAUDIO_RDFT_fuzzer-5718519492116480
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/binkaudio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavcodec/binkaudio.c b/libavcodec/binkaudio.c
> index 96cf968c66..2384ebf312 100644
> --- a/libavcodec/binkaudio.c
> +++ b/libavcodec/binkaudio.c
> @@ -95,6 +95,8 @@ static av_cold int decode_init(AVCodecContext *avctx)
>      if (avctx->codec->id == AV_CODEC_ID_BINKAUDIO_RDFT) {
>          // audio is already interleaved for the RDFT format variant
>          avctx->sample_fmt = AV_SAMPLE_FMT_FLT;
> +        if (sample_rate > INT_MAX / avctx->channels)
> +            return AVERROR_INVALIDDATA;
>          sample_rate  *= avctx->channels;
>          s->channels = 1;
>          if (!s->version_b)
> -- 
> 2.23.0

i think this checl belongs inside the fuzzer test harness, or as a general
purpose codec check.

the bink and smaker demuxers will only ever use BINKAUDIO_RDFT with 1 or 2 channels.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191011/e2876996/attachment.sig>