[FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

[Paul B Mahol]

lgtm

On 10/11/19, Michael Niedermayer <michael at niedermayer.cc> wrote:
> Fixes: signed integer overflow: 1092624416 * 2 cannot be represented in type
> 'int'
> Fixes:
> 18045/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINKAUDIO_RDFT_fuzzer-5718519492116480
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/binkaudio.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/binkaudio.c b/libavcodec/binkaudio.c
> index 96cf968c66..2384ebf312 100644
> --- a/libavcodec/binkaudio.c
> +++ b/libavcodec/binkaudio.c
> @@ -95,6 +95,8 @@ static av_cold int decode_init(AVCodecContext *avctx)
>      if (avctx->codec->id == AV_CODEC_ID_BINKAUDIO_RDFT) {
>          // audio is already interleaved for the RDFT format variant
>          avctx->sample_fmt = AV_SAMPLE_FMT_FLT;
> +        if (sample_rate > INT_MAX / avctx->channels)
> +            return AVERROR_INVALIDDATA;
>          sample_rate  *= avctx->channels;
>          s->channels = 1;
>          if (!s->version_b)
> --
> 2.23.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".