[FFmpeg-devel] [PATCH v1 2/2] avformat/libsrt: fix for the memory leak if passphrase has been configured by option

Limin Wang lance.lmwang at gmail.com
Fri Oct 11 04:01:12 EEST 2019


ping the patchset, one is memory leak, one is option type. Please help
to review.

On Fri, Sep 20, 2019 at 07:17:28PM +0800, lance.lmwang at gmail.com wrote:
> From: Limin Wang <lance.lmwang at gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
>  libavformat/libsrt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
> index 2fc6328c4e..2105317545 100644
> --- a/libavformat/libsrt.c
> +++ b/libavformat/libsrt.c
> @@ -493,6 +493,7 @@ static int libsrt_open(URLContext *h, const char *uri, int flags)
>              s->pbkeylen = strtol(buf, NULL, 10);
>          }
>          if (av_find_info_tag(buf, sizeof(buf), "passphrase", p)) {
> +            av_freep(&s->passphrase);
>              s->passphrase = av_strndup(buf, strlen(buf));
>          }
>          if (av_find_info_tag(buf, sizeof(buf), "mss", p)) {
> -- 
> 2.21.0
> 


More information about the ffmpeg-devel mailing list