[FFmpeg-devel] [PATCH 04/13] avfilter/af_anlms: switch to ff_filter_process_command()

Moritz Barsnick barsnick at gmx.net
Thu Oct 10 12:42:44 EEST 2019


On Wed, Oct 09, 2019 at 11:56:42 +0200, Paul B Mahol wrote:
> --- a/libavfilter/af_anlms.c
> +++ b/libavfilter/af_anlms.c
> @@ -60,13 +60,14 @@ typedef struct AudioNLMSContext {
>
>  #define OFFSET(x) offsetof(AudioNLMSContext, x)
>  #define A AV_OPT_FLAG_AUDIO_PARAM|AV_OPT_FLAG_FILTERING_PARAM
> +#define C AV_OPT_FLAG_COMMAND_PARAM

Perhaps, like in other filters, #define "AF" and "AFC"?

> +    { "mu",      "set the filter mu",      OFFSET(mu),      AV_OPT_TYPE_FLOAT, {.dbl=0.75}, 0, 1, A|C },

Avoids OR-ing to an already OR-ed value. (Readability only.)

Moritz


More information about the ffmpeg-devel mailing list