[FFmpeg-devel] [PATCH 09/14] avfilter/vf_amplify: add support for commands

[Paul B Mahol]

On 10/9/19, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Wed, Oct 09, 2019 at 12:17:00PM +0200, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  libavfilter/vf_amplify.c | 14 ++++++++------
>>  1 file changed, 8 insertions(+), 6 deletions(-)
> [...]
>> @@ -311,4 +312,5 @@ AVFilter ff_vf_amplify = {
>>      .init          = init,
>>      .uninit        = uninit,
>>      .flags         = AVFILTER_FLAG_SLICE_THREADS,
>> +    .process_command = ff_filter_process_command,
>
> maybe ff_filter_process_command() should be called by default if
> process_command is NULL

Maybe, but I prefer explicit solutions more.

>
> patch LGTM if tested
>
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The worst form of inequality is to try to make unequal things equal.
> -- Aristotle
>