[FFmpeg-devel] [PATCH] avformat/ivf: Change the length field to 32 bits

Derek Buitenhuis derek.buitenhuis at gmail.com
Tue Oct 1 22:09:02 EEST 2019


On 01/10/2019 18:25, James Almer wrote:
> The value in the unused field will be 0xFFFFFFFF after this change
> instead of 0, since you're writing 32 bits as duration instead of 64
> where the high 32 bits (corresponding to the unused field) are zeroed.
> That means the ivf demuxer prior to this patch will read bogus duration
> values from ivf files created after this patch.
> 
> Just leave the muxer as is.

Why not just write zero?

It's, to me, worse to leave a bogus 64-bit write to appease bugs in our
own demuxer. It's confusing and misleading for any readers of the code.

- Derek


More information about the ffmpeg-devel mailing list