[FFmpeg-devel] [PATCH v5 2/4] lavc/libxavs2: optimize data access

[Michael Niedermayer]

On Sat, Nov 30, 2019 at 01:21:25PM +0800, hwren wrote:
> 
> 
> 
> 
> 
> 
> 
> 
> 
> At 2019-11-30 02:39:07, "Michael Niedermayer" <michael at niedermayer.cc> wrote:
> >On Mon, Oct 14, 2019 at 09:22:43PM +0800, hwren wrote:
> >> Optimize data access from multiplication to iteration.
> >> 
> >> Signed-off-by: hwren <hwrenx at 126.com>
> >> ---
> >>  libavcodec/libxavs2.c | 45 +++++++++++++++++++++++++++++----------------
> >>  1 file changed, 29 insertions(+), 16 deletions(-)
> >
> >I think the change is ok but the commit message is hard to understand
> >
> 
> >thx
> 
> 
> I'm not sure which way is better to describe this commit. What I did was use iterative addressing instead of multiplicative addressing. So, maybe it's better to use message like Optimize data addressingor like Use iterative addressing instead of multiplicative addressing? I would be appreciate if you could give me some suggestions.

you could have one commit whith a commit message like
"Use more descriptive variable names in xavs2_copy_frame*()"

And a 2nd commit with
"Avoid recomputing pointers and instead update them in xavs2_copy_frame*()"


Thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191130/2f57589f/attachment.sig>