[FFmpeg-devel] [PATCH] libavdevice/lavfi: check avfilter_graph_dump return value

[zhilizhao]

Ping for review, thanks!

> On Nov 21, 2019, at 3:08 PM, quinkblack at foxmail.com wrote:
> 
> From: Zhao Zhili <zhilizhao at tencent.com>
> 
> ---
> libavdevice/lavfi.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c
> index ca8f05f3f7..c949ff7e12 100644
> --- a/libavdevice/lavfi.c
> +++ b/libavdevice/lavfi.c
> @@ -302,9 +302,13 @@ av_cold static int lavfi_read_header(AVFormatContext *avctx)
> 
>     if (lavfi->dump_graph) {
>         char *dump = avfilter_graph_dump(lavfi->graph, lavfi->dump_graph);
> -        fputs(dump, stderr);
> -        fflush(stderr);
> -        av_free(dump);
> +        if (dump != NULL) {
> +            fputs(dump, stderr);
> +            fflush(stderr);
> +            av_free(dump);
> +        } else {
> +            FAIL(AVERROR(ENOMEM));
> +        }
>     }
> 
>     /* fill each stream with the information in the corresponding sink */
> -- 
> 2.22.0
>