[FFmpeg-devel] [PATCH] avformat/hlsenc: remove duplicate code block

[Michael Niedermayer]

On Wed, Nov 27, 2019 at 05:43:09PM +0800, Steven Liu wrote:
> Signed-off-by: Steven Liu <lq at chinaffmpeg.org>
> ---
>  libavformat/hlsenc.c | 23 ++++-------------------
>  1 file changed, 4 insertions(+), 19 deletions(-)

this breaks the code

./ffmpeg_g -i mm-short.mpg -i fate-suite/sub/MovText_capability_tester.mp4  -f hls  -c:a aac -hls_segment_filename /tmp/file-v.low.%d.ts -t 10 /tmp/file-v.low.m3u8

...
==5612== Invalid read of size 8
==5612==    at 0x800AC8: avformat_free_context (in ffmpeg/ffmpeg_g)
==5612==    by 0x710A9B: hls_free_variant_streams.isra.12 (in ffmpeg/ffmpeg_g)
==5612==    by 0x714EB3: hls_write_trailer (in ffmpeg/ffmpeg_g)
==5612==    by 0x78341A: av_write_trailer (in ffmpeg/ffmpeg_g)
==5612==    by 0x4D9E88: transcode (in ffmpeg/ffmpeg_g)
==5612==    by 0x4B5D3C: main (in ffmpeg/ffmpeg_g)
==5612==  Address 0x464b0c50 is 16 bytes inside a block of size 1,504 free'd
==5612==    at 0x4C2B5D9: free (vg_replace_malloc.c:446)
==5612==    by 0x800D97: avformat_free_context (in ffmpeg/ffmpeg_g)
==5612==    by 0x714AF9: hls_write_trailer (in ffmpeg/ffmpeg_g)
==5612==    by 0x78341A: av_write_trailer (in ffmpeg/ffmpeg_g)
==5612==    by 0x4D9E88: transcode (in ffmpeg/ffmpeg_g)
==5612==    by 0x4B5D3C: main (in ffmpeg/ffmpeg_g)
==5612== 
==5612== Invalid read of size 8
==5612==    at 0x119430E: av_opt_free (in ffmpeg/ffmpeg_g)
==5612==    by 0x800AF6: avformat_free_context (in ffmpeg/ffmpeg_g)
==5612==    by 0x710A9B: hls_free_variant_streams.isra.12 (in ffmpeg/ffmpeg_g)
==5612==    by 0x714EB3: hls_write_trailer (in ffmpeg/ffmpeg_g)
==5612==    by 0x78341A: av_write_trailer (in ffmpeg/ffmpeg_g)
==5612==    by 0x4D9E88: transcode (in ffmpeg/ffmpeg_g)
==5612==    by 0x4B5D3C: main (in ffmpeg/ffmpeg_g)
==5612==  Address 0x464b0c40 is 0 bytes inside a block of size 1,504 free'd
==5612==    at 0x4C2B5D9: free (vg_replace_malloc.c:446)
==5612==    by 0x800D97: avformat_free_context (in ffmpeg/ffmpeg_g)
==5612==    by 0x714AF9: hls_write_trailer (in ffmpeg/ffmpeg_g)
==5612==    by 0x78341A: av_write_trailer (in ffmpeg/ffmpeg_g)
==5612==    by 0x4D9E88: transcode (in ffmpeg/ffmpeg_g)
==5612==    by 0x4B5D3C: main (in ffmpeg/ffmpeg_g)
==5612== 
==5612== Invalid read of size 8
==5612==    at 0x118EBA3: av_freep (in ffmpeg/ffmpeg_g)
==5612==    by 0x119434E: av_opt_free (in ffmpeg/ffmpeg_g)
==5612==    by 0x800AF6: avformat_free_context (in ffmpeg/ffmpeg_g)
==5612==    by 0x710A9B: hls_free_variant_streams.isra.12 (in ffmpeg/ffmpeg_g)
==5612==    by 0x714EB3: hls_write_trailer (in ffmpeg/ffmpeg_g)
==5612==    by 0x78341A: av_write_trailer (in ffmpeg/ffmpeg_g)
==5612==    by 0x4D9E88: transcode (in ffmpeg/ffmpeg_g)
==5612==    by 0x4B5D3C: main (in ffmpeg/ffmpeg_g)
==5612==  Address 0x464b10b8 is 1,144 bytes inside a block of size 1,504 free'd
==5612==    at 0x4C2B5D9: free (vg_replace_malloc.c:446)
==5612==    by 0x800D97: avformat_free_context (in ffmpeg/ffmpeg_g)
==5612==    by 0x714AF9: hls_write_trailer (in ffmpeg/ffmpeg_g)
==5612==    by 0x78341A: av_write_trailer (in ffmpeg/ffmpeg_g)
==5612==    by 0x4D9E88: transcode (in ffmpeg/ffmpeg_g)
==5612==    by 0x4B5D3C: main (in ffmpeg/ffmpeg_g)

If you cannot reproduce, tell me and ill rerun this with full debug symbols (line numbers)

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191127/e80b156b/attachment.sig>