[FFmpeg-devel] [PATCH] lavc/libx264: enable the PC(2^n -1) colorspace in libx264rgb

[Carl Eugen Hoyos]

> Am 27.11.2019 um 10:52 schrieb Jun Zhao <mypopydev at gmail.com>:
> 
> From: Jun Zhao <barryjzhao at tencent.com>
> 
> enable the PC(2^n -1) colorspace in libx264rgb
> 
> fix #8404
> 
> Signed-off-by: Jun Zhao <barryjzhao at tencent.com>
> ---
> libavcodec/libx264.c |    5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
> index bfd91bb..60607ca 100644
> --- a/libavcodec/libx264.c
> +++ b/libavcodec/libx264.c
> @@ -867,6 +867,11 @@ FF_ENABLE_DEPRECATION_WARNINGS
>     x4->params.vui.b_fullrange = avctx->pix_fmt == AV_PIX_FMT_YUVJ420P ||
>                                  avctx->pix_fmt == AV_PIX_FMT_YUVJ422P ||
>                                  avctx->pix_fmt == AV_PIX_FMT_YUVJ444P ||

> +#if CONFIG_LIBX264RGB_ENCODER

The #if looks unneeded...

> +                                 avctx->pix_fmt == AV_PIX_FMT_BGR0 ||
> +                                 avctx->pix_fmt == AV_PIX_FMT_BGR24 ||
> +                                 avctx->pix_fmt == AV_PIX_FMT_RGB24 ||

... but why don’t you check for the actually used encoder instead?

Also, you may have to check that the range wasn’t explicitly set to mpeg.

> +#endif
>                                  avctx->color_range == AVCOL_RANGE_JPEG;

Carl Eugen