[FFmpeg-devel] [PATCH] avformat/avlanguage: deprecate av_convert_lang_to and make it internal

[James Almer]

On 11/26/2019 9:29 PM, Aman Gupta wrote:
> On Fri, May 13, 2016 at 2:29 PM James Almer <jamrial at gmail.com> wrote:
> 
>> The header was never installed and the function is only used in libavformat
>>
> 
> I think av_convert_lang_to would be a useful public function. Do you mind
> if I redefine it, and export the header this time?
> 
> libavformat returns iso639-2 codes in AVStream.metadata's "language" entry.
> This can be problematic on some platforms like iOS where NSLocale can only
> understand iso639-1 codes. ff_convert_lang_to is used for the same purpose
> internally, so exposing it would make it easier for users to perform the
> same conversion.
> 
> Aman

Feel free to send a patch. I was doing some ABI clean up when i
committed this, and have no opinion on this functionality. Others might,
though.

Also, you made me realize i never deleted the dead code left after the
bump in avlanguage.*