[FFmpeg-devel] [PATCH] avformat/hlsenc: set strict_std_compliance from the parent AVFormatContext

[Steven Liu]

> 在 2019年11月25日，06:36，Jan Ekström <jeebjp at gmail.com> 写道：
> 
> Hi,
> 
> On Wed, Nov 20, 2019 at 11:26 AM Steven Liu <lq at chinaffmpeg.org> wrote:
>> 
>> fix ticket: 8388
>> 
>> Signed-off-by: Steven Liu <lq at chinaffmpeg.org>
>> ---
> 
> Too bad meta things that end up creating internal contexts end up
> messy like this.
> 
> Generally same idea as with bad42e9b40920f079b27e5bd4103d9293046b2ed ,
> so other than the following nit regarding extraneous white space on
> the newly added line, LGTM.
> 
> Possibly also utilize similar wording as the other commit, but I have
> no heavy opinion on that :) .
> 
>> libavformat/hlsenc.c | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
>> index 013e91ad88..24c102f570 100644
>> --- a/libavformat/hlsenc.c
>> +++ b/libavformat/hlsenc.c
>> @@ -782,6 +782,7 @@ static int hls_mux_init(AVFormatContext *s, VariantStream *vs)
>>     oc->opaque             = s->opaque;
>>     oc->io_open            = s->io_open;
>>     oc->io_close           = s->io_close;
>> +    oc->strict_std_compliance     = s->strict_std_compliance;
> 
> Adds extraneous white space. A single space before the equals sign
> goes just fine here since this is the longest line in the set. I'd
> just do the following to be honest:
> 
> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
> index 013e91ad88..519d489956 100644
> --- a/libavformat/hlsenc.c
> +++ b/libavformat/hlsenc.c
> @@ -776,12 +776,13 @@ static int hls_mux_init(AVFormatContext *s,
> VariantStream *vs)
>     if (!oc->url)
>         return AVERROR(ENOMEM);
> 
> -    oc->oformat            = vs->oformat;
> -    oc->interrupt_callback = s->interrupt_callback;
> -    oc->max_delay          = s->max_delay;
> -    oc->opaque             = s->opaque;
> -    oc->io_open            = s->io_open;
> -    oc->io_close           = s->io_close;
> +    oc->oformat               = vs->oformat;
> +    oc->interrupt_callback    = s->interrupt_callback;
> +    oc->max_delay             = s->max_delay;
> +    oc->opaque                = s->opaque;
> +    oc->io_open               = s->io_open;
> +    oc->io_close              = s->io_close;
> +    oc->strict_std_compliance = s->strict_std_compliance;
>     av_dict_copy(&oc->metadata, s->metadata, 0);
> 
>     if (vs->vtt_oformat) {
> 
> Best regards,
> Jan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe”.

Pushed with JEEB’s suggestion.

Thanks
Steven