[FFmpeg-devel] [PATCH] avfilter/vf_nlmeans: add >8 bit support

[Paul B Mahol]

Easy to fix, do you have another comment?

On 11/21/19, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Wed, Nov 20, 2019 at 10:54:42AM +0100, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  libavfilter/aarch64/vf_nlmeans_init.c |   6 +-
>>  libavfilter/nlmeans_template.c        | 370 ++++++++++++++++++
>>  libavfilter/vf_nlmeans.c              | 539 ++++++--------------------
>>  libavfilter/vf_nlmeans.h              |  59 ++-
>>  4 files changed, 548 insertions(+), 426 deletions(-)
>>  create mode 100644 libavfilter/nlmeans_template.c
>
> breaks:
>
> make testprogs
> CC	libavfilter/tests/integral.o
> libavfilter/tests/integral.c: In function ‘main’:
> libavfilter/tests/integral.c:66:5: error: too few arguments to function
> ‘ff_nlmeans_init’
>      ff_nlmeans_init(&dsp);
>      ^
> In file included from libavfilter/tests/integral.c:19:0:
> ./libavfilter/vf_nlmeans.c:131:6: note: declared here
>  void ff_nlmeans_init(NLMeansDSPContext *dsp, int depth)
>       ^
> libavfilter/tests/integral.c:72:13: error: implicit declaration of function
> ‘compute_ssd_integral_image’ [-Werror=implicit-function-declaration]
>              compute_ssd_integral_image(&dsp, ii_start, ii_lz_32,
>              ^
> libavfilter/tests/integral.c:76:13: error: implicit declaration of function
> ‘compute_unsafe_ssd_integral_image’ [-Werror=implicit-function-declaration]
>              compute_unsafe_ssd_integral_image(ii_start2, ii_lz_32,
>              ^
> cc1: some warnings being treated as errors
> make: *** [libavfilter/tests/integral.o] Error 1
> make: Target `testprogs' not remade because of errors.
>
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
>