[FFmpeg-devel] [PATCH v1 2/2] configure: Fix for the configure failed for vmaf

[zhilizhao]

> On Nov 14, 2019, at 8:56 AM, Limin Wang <lance.lmwang at gmail.com> wrote:
> 
> On Thu, Nov 14, 2019 at 01:03:09AM +0800, Zhao Zhili wrote:
>> 
>> 
>>> On Nov 13, 2019, at 9:41 PM, Zhong Li <lizhong1008 at gmail.com> wrote:
>>> 
>>> Just curious why this issue hasn't been found earlier.
>> 
>> I think it's a regression of libvmaf:
>> 	libvmaf: build with meson
>> 	https://github.com/Netflix/vmaf/commit/82a86e040371f2ca8665d6c210e3d1d2d608a636
>> 
>> I have a pull request for it:
>> 	https://github.com/Netflix/vmaf/pull/394
> 
> Most of 3rdparty library pkg prefer not to use lib* prefix, for example:
> x264.pc, x265.pc, ffnvcodec.pc, fdk-aac.pc, srt.pc etc 
> 
> So if libvmaf can keep it same rule, it's better to fix here.


It doesn’t matter whether it has the ‘lib’ prefix or not, just don’t break the build.

The rename was committed 13 days ago, so the patch will break a lot of build, e.g.

/usr/local/lib/pkgconfig$ cat libvmaf.pc
prefix=/usr/local
exec_prefix=${prefix}
libdir=/usr/local/lib
includedir=/usr/local/include

Name: libvmaf
Description: Netflix's VMAF library
Version: 1.3.14


> 
> 
>> 
>>> 
>>> <lance.lmwang at gmail.com> 于2019年11月12日周二 下午7:24写道：
>>>> 
>>>> From: Limin Wang <lance.lmwang at gmail.com>
>>>> 
>>>> When enable-libvmaf with the vmaf master installed , it'll report below error:
>>>> ERROR: libvmaf >= 1.3.9 not found using pkg-config
>>>> 
>>>> In fact, after vmaf installed, the vmaf pkg-config filename is vmaf.pc,
>>>> my build system is Centos7.4.
>>>> 
>>>> Below is the debug info for why change libvmaf to vmaf in the patch:
>>>> $ PKG_CONFIG_PATH=$your_pkg_path pkg-config --modversion libvmaf
>>>> Package libvmaf was not found in the pkg-config search path.
>>>> Perhaps you should add the directory containing `libvmaf.pc'
>>>> to the PKG_CONFIG_PATH environment variable
>>>> No package 'libvmaf' found
>>>> 
>>>> $ PKG_CONFIG_PATH=$your_pkg_path pkg-config --modversion vmaf
>>>> 1.3.16
>>>> 
>>>> $ ls ../../../3rdparty_img/lib/pkgconfig/vmaf.pc
>>>> ../../../3rdparty_img/lib/pkgconfig/vmaf.pc
>>>> $ cat ../../../3rdparty_img/lib/pkgconfig/vmaf.pc
>>>> prefix=/home/lmwang/build/build_ffmpeg/../3rdparty_img
>>>> libdir=${prefix}/lib
>>>> includedir=${prefix}/include
>>>> 
>>>> Name: libvmaf
>>>> Description: VMAF, Video Multimethod Assessment Fusion
>>>> Version: 1.3.16
>>>> Libs: -L${libdir} -lvmaf
>>>> Libs.private: -lpthread
>>>> Cflags: -I${includedir}
>>>> 
>>>> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
>>>> ---
>>>> configure | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>> 
>>>> diff --git a/configure b/configure
>>>> index 1de90e9..308ed3c 100755
>>>> --- a/configure
>>>> +++ b/configure
>>>> @@ -6312,7 +6312,7 @@ enabled libtwolame        && require libtwolame twolame.h twolame_init -ltwolame
>>>>                               die "ERROR: libtwolame must be installed and version must be >= 0.3.10"; }
>>>> enabled libv4l2           && require_pkg_config libv4l2 libv4l2 libv4l2.h v4l2_ioctl
>>>> enabled libvidstab        && require_pkg_config libvidstab "vidstab >= 0.98" vid.stab/libvidstab.h vsMotionDetectInit
>>>> -enabled libvmaf           && require_pkg_config libvmaf "libvmaf >= 1.3.9" libvmaf.h compute_vmaf
>>>> +enabled libvmaf           && require_pkg_config libvmaf "vmaf >= 1.3.9" libvmaf.h compute_vmaf
>>>> enabled libvo_amrwbenc    && require libvo_amrwbenc vo-amrwbenc/enc_if.h E_IF_init -lvo-amrwbenc
>>>> enabled libvorbis         && require_pkg_config libvorbis vorbis vorbis/codec.h vorbis_info_init &&
>>>>                             require_pkg_config libvorbisenc vorbisenc vorbis/vorbisenc.h vorbis_encode_init
>>>> --
>>>> 2.9.5
>>>> 
>>>> _______________________________________________
>>>> ffmpeg-devel mailing list
>>>> ffmpeg-devel at ffmpeg.org
>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>> 
>>>> To unsubscribe, visit link above, or email
>>>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel at ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>> 
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>> 
>> 
>> 
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".