[FFmpeg-devel] [PATCH] avcodec/vp9_raw_reorder_bsf.c fix deadcode

Michael Niedermayer michael at niedermayer.cc
Sat Nov 9 00:41:23 EET 2019


On Fri, Nov 08, 2019 at 10:29:42AM +0800, darling.zhong wrote:
> Here if (in->data[in->size - 1] & 0) nerver true?
> 
> 
> Signed-off-by: darling.zhong <dalingzhong at yeah.net>
> ---
>  libavcodec/vp9_raw_reorder_bsf.c | 2 +-
>  patcheck.tmp                     | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  mode change 100644 => 100755 libavcodec/vp9_raw_reorder_bsf.c
>  create mode 100644 patcheck.tmp
> 
> 
> diff --git a/libavcodec/vp9_raw_reorder_bsf.c b/libavcodec/vp9_raw_reorder_bsf.c
> old mode 100644
> new mode 100755
> index f19b4c7198..e55a358457
> --- a/libavcodec/vp9_raw_reorder_bsf.c
> +++ b/libavcodec/vp9_raw_reorder_bsf.c
> @@ -292,7 +292,7 @@ static int vp9_raw_reorder_filter(AVBSFContext *bsf, AVPacket *out)
>              return err;
>          }
>  
> -        if (in->data[in->size - 1] & 0xe0 == 0xc0) {
> +        if ((in->data[in->size - 1] & 0xe0) == 0xc0) {
>              av_log(bsf, AV_LOG_ERROR, "Input in superframes is not "
>                     "supported.\n");
>              av_packet_free(&in);

> diff --git a/patcheck.tmp b/patcheck.tmp
> new file mode 100644
> index 0000000000..e69de29bb2

this should not be in the patch

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191108/71fdd0b4/attachment.sig>


More information about the ffmpeg-devel mailing list