[FFmpeg-devel] [FFmpeg-cvslog] avcodec/libvpxdec: reject video and alpha dimension mismatches

[James Zern]

On Wed, Nov 6, 2019 at 2:21 AM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>
> Am Mi., 6. Nov. 2019 um 08:28 Uhr schrieb Marton Balint <git at videolan.org>:
> > [...]
> > +        if (ctx->has_alpha_channel &&
> > +            (img->d_w != img_alpha->d_w ||
> > +             img->d_h != img_alpha->d_h ||
> > +             img->bit_depth != img_alpha->bit_depth)) {
> > +            av_log(avctx, AV_LOG_ERROR,
> > +                   "Video dimensions %dx%d@%dbpp differ from alpha dimensions %dx%d@%dbpp\n",
> > +                   img->d_w, img->d_h, img->bit_depth,
> > +                   img_alpha->d_w, img_alpha->d_h, img_alpha->bit_depth);
> > +            return AVERROR_INVALIDDATA;
>
> Shouldn't this be "bpc" instead of "bpp"?
>

I tend to use them interchangeably, but bpc may be more precise here.
I sent a patch.