[FFmpeg-devel] [PATCH] Support for zulu timezone format for PDT in HLS playlists

Steven Liu lq at chinaffmpeg.org
Mon Nov 4 04:25:14 EET 2019



> 在 2019年11月3日,20:14,Marton Balint <cus at passwd.hu> 写道:
> 
> 
> 
> On Fri, 25 Oct 2019, Ole Andre Birkedal wrote:
> 
>> I think this is the best solution, with just one new flag +utc_pdt that will force timestamps of PDT to be in UTC with the format YYYY-MM-DDThh:mm:ssZ. Too many flags will be confusing, and the "zulu" name can be a bit confusing so I removed any mention of that.
> 
> Agreed.
> 
> + at item utc_pdt
> +Always use UTC timezone in @code{EXT-X-PROGRAM-DATE-TIME} tags with format
> + at code{#EXT-X-PROGRAM-DATE-TIME:<YYYY-MM-DDThh:mm:ssZ>}.
> +
> 
> The format is not entirely correct, miliseconds are also part of the output.
> 
> +        // Generate correct offset string if we're not using UTC
> +        if (!utc_pdt && !strftime(buf1, sizeof(buf1), "%z", tm) ||
> +            buf1[1]<'0' || buf1[1]>'2') {
> 
> There seems to be an operator precedence issue here.
> 
> Other than that looks good, but Steven Liu is the maintainer of hls.
Looks ok too.
> 
> Regards,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

Thanks
Steven







More information about the ffmpeg-devel mailing list