[FFmpeg-devel] [PATCH] avdevice/v4l2: Change assert type when format not supported

[Carl Eugen Hoyos]

Am So., 3. Nov. 2019 um 18:03 Uhr schrieb Andriy Gelman
<andriy.gelman at gmail.com>:
>
> On Sun, 03. Nov 17:37, Nicolas George wrote:
> > Andriy Gelman (12019-11-03):
> > > From: Andriy Gelman <andriy.gelman at gmail.com>
> > >
> > > Currently an av_assert0 is triggered when a target format is not
> > > supported by a v4l2 device. Replace by av_assert1 to fix this issue.
> > >
> > > Fixes #6629.
> >
> > No. It does not fix it, it just hides it in non-devel builds.
>
> Fine with me if you want to change
>
> "Replace by av_assert1 to fix this issue" -> "Replace by av_assert1 to hide in
> non-devel builds"

To address this ticket, only a patch that changes behaviour no matter what
assertion level was chosen at build time is acceptable
(= fix the wrong condition, not the check or remove the check if it is wrong).

Carl Eugen