[FFmpeg-devel] [PATCH] avfilter: add eval video filter

Michael Niedermayer michael at niedermayer.cc
Fri Nov 1 20:29:45 EET 2019


On Fri, Nov 01, 2019 at 04:50:38PM +0100, Paul B Mahol wrote:
> On 11/1/19, Michael Niedermayer <michael at niedermayer.cc> wrote:
> > On Fri, Nov 01, 2019 at 01:09:24PM +0100, Paul B Mahol wrote:
> >> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> >> ---
> >>  doc/filters.texi         |  78 +++++
> >>  libavfilter/Makefile     |   1 +
> >>  libavfilter/allfilters.c |   1 +
> >>  libavfilter/vf_eval.c    | 687 +++++++++++++++++++++++++++++++++++++++
> >>  4 files changed, 767 insertions(+)
> >>  create mode 100644 libavfilter/vf_eval.c
> >
> > This looks like it duplicates code from vf_geq.c
> > also this should be integrated with or in vf_geq.c
> >
> > IIUC this was written because geq is GPL, but i had already agreed to
> > relicense the code in it i wrote to LGPL, so iam not sure why you wrote
> > this.
> >
> > Who disagreed to relicnce their contribution to geq to avoid this extra
> > work you did ?
> > Or did noone disagree ? then i do not understand why you wrote a seperate
> > filter
> 
> Do I need to contact all on blame list of vf_geq? or also mplayer devs
> that touched geq in mplayer?

all who touched it MINUS anyone who made a change that is totally not
in the current version (there are several developers in mplayer who
made auch changes)
also in case of mplayer you may need to look at the commit messages
some developers did apply patches from others.

I took a quick look and these are the people i saw
carl, ubitux, ivan, ods15, Alexis Ballier, derek, Marc-Antoine Arnaud, Nicolas George, Stefano and Paul
reimar, zuxy and diego

For the last 3 i could not find a change that persists in the current
code

Either way please check the list of names, i may have made a mistake!

Thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191101/b1225c8d/attachment.sig>


More information about the ffmpeg-devel mailing list