[FFmpeg-devel] [PATCH] avcodec/gdv: Check remaining output after decode 5/6/8/

[Michael Niedermayer]

On Thu, May 30, 2019 at 11:28:35AM +0200, Paul B Mahol wrote:
> On 5/29/19, Michael Niedermayer <michael at niedermayer.cc> wrote:
> > Improves: Timeout (355sec -> 97sec)
> > Improves:
> > 14709/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_GDV_fuzzer-5704215281795072
> >
> > Found-by: continuous fuzzing process
> > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > ---
> >  libavcodec/gdv.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/gdv.c b/libavcodec/gdv.c
> > index 9cf30c09e4..a5ce6b799e 100644
> > --- a/libavcodec/gdv.c
> > +++ b/libavcodec/gdv.c
> > @@ -308,7 +308,7 @@ static int decompress_5(AVCodecContext *avctx, unsigned
> > skip)
> >              int len;
> >              int b = bytestream2_get_byte(gb);
> >              if (b == 0) {
> > -                break;
> > +                return 0;
> 
> Why?

i have no testcase for this path, so i did not route it through the new check
but i surely can treat it the same as others if you want ?

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190531/fbd793c0/attachment.sig>