[FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

[Sun, Jing A]

-----Original Message-----
From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of James Almer
Sent: Friday, May 31, 2019 11:17 AM
To: ffmpeg-devel at ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

>You should return 0 here. AVCodec.encode2() must not return AVERROR_EOF.
>Anything < 0 is considered an error.
>Since this can only happen after EOF, a return value of 0 and *got_packet == 0 will effectively signal EOF.
>Use PRId64 instead of ld.

Thanks so much for the review! Modified and please kindly review again. 

Regards,
Sun, Jing