[FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

[Moritz Barsnick]

On Wed, May 29, 2019 at 19:28:24 +0100, Derek Buitenhuis wrote:
> +during configuration. You need to explicitly configue the build with
                                                ^ configure

> +Sets the maximum qauntizer (floor) to use when using bitrate mode.
                    ^ quantizer

> +Set rav1e options using a list of @var{key}=@var{value} couples separated

I believe they're mostly referred to as "pairs", but it doesn't really
matter.

> +For example to specify librav1e encoding options with @option{-rav1e-params}:

So are they "rav1e options" or "librav1e [encoding] options"? Just
wondering.

> +        av_log(avctx, AV_LOG_ERROR, "Invalid width passed to rav1e.\n");
> +        ret = AVERROR_INVALIDDATA;

Isn't AVERROR_INVALIDDATA meant for invalid *stream* data? Not invalid
options. I believe other codecs return AVERROR(EINVAL).

> +            av_log(avctx, AV_LOG_ERROR, "Could not set max quantizer.\n");
> +            ret = AVERROR_EXTERNAL;

How is this different?

> +    ctx->ctx = rav1e_context_new(cfg);
> +    if (!ctx->ctx) {
> +        av_log(avctx, AV_LOG_ERROR, "Failed to create rav1e encode context.\n");
> +        ret = AVERROR_EXTERNAL;

This, OTOH, looks correct.

Cheers,
Moritz