[FFmpeg-devel] [PATCH] avformat/cache - delete cache file after closing handle

[Hendrik Leppkes]

On Thu, May 23, 2019 at 9:55 PM Gyan <ffmpeg at gyani.pro> wrote:
>
>
>
> On 24-05-2019 12:58 AM, Nicolas George wrote:
> > Gyan (12019-05-24):
> >> avpriv_io_delete will call the file protocol's delete which is guarded
> >> with a header check, not done here.
> > Do you have report of a build failure caused by unlink()?
>
> No.  I assume that the guard in the file proto callback is germane and
> the patch was subject to review. Do you know it isn't?
>
> >> Since we now have a generic wrapper function, isn't that better for
> >> future maintenance?
> > Not that I see. Something that makes it harder to follow the code from
> > the call site to the actual function is not good for maintenance.
> The point of modularizing the op here is to have a single interface -
> why stick with a direct external call? At the time it was added, there
> was no alternative.
> Don't mind it either way, but this feels like a useless game of ping-pong.
>

Just stick to unlink. If there is no reason to change it, then the
preference is to just keep it as-is.
We're not using the file protocol to create the file, so no reason to
use it to delete it.

- Hendrik