[FFmpeg-devel] [PATCH] avformat/cache - delete cache file after closing handle

Nicolas George george at nsup.org
Thu May 23 22:28:43 EEST 2019


Gyan (12019-05-24):
> avpriv_io_delete will call the file protocol's delete which is guarded
> with a header check, not done here.

Do you have report of a build failure caused by unlink()?

> Since we now have a generic wrapper function, isn't that better for
> future maintenance?

Not that I see. Something that makes it harder to follow the code from
the call site to the actual function is not good for maintenance.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190523/c8a15d16/attachment.sig>


More information about the ffmpeg-devel mailing list