[FFmpeg-devel] [FFMPEG DEVEL] [PATCH v4] fftools/ffprobe: Add S12M Timecode output as side data (such as SEI TC)

[Marton Balint]

On Sun, 19 May 2019, Antonin Gouzer wrote:

> ---
> Add the index of the timecode in case of multiple timecodes values
> Limit to 3 the number of timecodes
> remove break

Am I reading this correctly, you'd get XML like

<side_data side_data_type="SMPTE 12-1 timecode" timecode="00:03:25:03" id="1"/>
<side_data side_data_type="SMPTE 12-1 timecode" timecode="00:03:25:03" id="2"/>
<side_data side_data_type="SMPTE 12-1 timecode" timecode="00:03:25:03" id="3"/>

right? The problem is that your output now looks as if the frame have 3 
instances of SMPTE 12-1 timecode side data.

Maybe it's just me, but I'd prefer something like

<side_data side_data_type="SMPTE 12-1 timecode">
<timecode>00:03:25:03</timecode>
<timecode>00:03:25:03</timecode>
<timecode>00:03:25:03</timecode>
</side_data>

What do you think?

Thanks,
Marton