[FFmpeg-devel] [PATCH 2/2] avformat/aviobuf: Forward error codes in avio_seek

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Tue May 14 18:34:00 EEST 2019


Michael Niedermayer:
> On Tue, May 14, 2019 at 10:49:49AM +0200, Andreas Rheinhardt wrote:
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
>> ---
>>  libavformat/aviobuf.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> do you have some testcase for this ?
> 
> thanks
> 
Honestly, no. I just read the code.
(Btw: Thinking of the bigger picture, there is something even weirder:
If an error happens (i.e. an AVIOContext's error is set) and one
performs a successfull seek, then error will still be set, yet
eof_reached will be cleared, although the latter is supposed to be
always set when error is set, isn't it? The same thing can happen when
one calls avio_feof on the AVIOContext.)

- Andreas



More information about the ffmpeg-devel mailing list