[FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

[Moritz Barsnick]

On Mon, May 13, 2019 at 12:54:58 +0530, Gyan wrote:
> >> Since 2.0.6 it works on Windows too.
> > Ping.
>
> Michael needs to confirm whether the build failure he had was due to his
> SDL version < 2.0.5

I can at least confirm that 2.0.4, which I have installed on one
machine, doesn't define this in the provided headers, and that ffmpeg
doesn't build against 2.0.4 with this patch. So there should be an
#ifdef SDL_WINDOW_ALWAYS_ON_TOP guard around this, and possibly around
the options definition. (And the docs should mention it?)

https://hg.libsdl.org/SDL/annotate/3beca914a2ad/include/SDL_video.h

Not sure how Windows behaves if compiled against 2.0.5 with
availability of the flag, but not the feature. ;-) [*]

BTW, would this also be an option which could go into the "sdl2" output
device? (I'm not happy with separate code bases for these, personally.)

Moritz

[*] My guess is that Windows just ignored this flag before its
implementation:
https://hg.libsdl.org/SDL/rev/2653833db94e